Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): fix regex pattern in ontology form (DSP-1139) #483

merged 3 commits into from Jul 13, 2021


Copy link

@kilchenmann kilchenmann commented Jul 12, 2021

resolves DSP-1139

We had an issue in the "create ontology" form. The regex didn't work as expected. As the DSP-API documentation says: "An ontology name must be a valid XML NCName. [...] A user-created ontology name may not start with the letter v followed by a digit". Special characters (incl. Umlauts etc), spaces and leading numbers are not allowed.
In this PR I fixed the regex and turned off the autocomplete (because it hides the error message below the field).

@kilchenmann kilchenmann added the bug A bug fix label Jul 12, 2021
@kilchenmann kilchenmann self-assigned this Jul 12, 2021
@kilchenmann kilchenmann requested review from mdelez and waychal and removed request for waychal and mdelez July 12, 2021 15:37
@kilchenmann kilchenmann marked this pull request as draft July 12, 2021 15:43
@kilchenmann kilchenmann marked this pull request as ready for review July 12, 2021 20:02
Copy link

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@kilchenmann kilchenmann merged commit 4d0703f into main Jul 13, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1139-regex-ontology-name branch July 13, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug A bug fix
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants