Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): optimize resource instance form (DSP-1256) #518

merged 6 commits into from Sep 6, 2021


Copy link

resolves DSP-1256

@kilchenmann kilchenmann self-assigned this Sep 3, 2021
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign labels Sep 3, 2021
Copy link

mdelez commented Sep 6, 2021

Screen Shot 2021-09-06 at 11 39 51

I made a small fix by providing the canDelete input to the app-display-edit component as well as adding the deleteValueIsAllowed method to the properties component. Can I push my changes? Otherwise it looks good! There is a weird css issue in the add-value component but that can be handled in another PR.

Copy link
Contributor Author

Thank you @mdelez
Yes, I will fix the css issue in a separate PR this afternoon. It will be part of the first refactoring. If it's okay I will merge this PR first...

@kilchenmann kilchenmann merged commit 5151677 into main Sep 6, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1256-second-try branch September 6, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug A bug fix enhancement New feature or request refactor Refactor or redesign
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants