Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(still-image): new draw region icon (DEV-569) #689

Merged
merged 4 commits into from Mar 22, 2022
Merged

feat(still-image): new draw region icon (DEV-569) #689

merged 4 commits into from Mar 22, 2022

Conversation

kilchenmann
Copy link
Contributor

resolves DEV-569

@kilchenmann kilchenmann self-assigned this Mar 22, 2022
@kilchenmann kilchenmann added the styling Update style; no production code change label Mar 22, 2022
@kilchenmann kilchenmann requested a review from mdelez March 22, 2022 13:45
mdelez
mdelez reviewed Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly related to this PR but since we're working on this component we should remove the asterisks from the add region form
Screen Shot 2022-03-22 at 15 13 47

@kilchenmann
Copy link
Contributor Author

It's not exactly related to this PR but since we're working on this component we should remove the asterisks from the add region form

oh yes, I haven't seen this one. I can do it.

mdelez
mdelez approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kilchenmann kilchenmann merged commit bee5caf into main Mar 22, 2022
@kilchenmann kilchenmann deleted the wip/dev-569-replace-region-icon branch March 22, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@kilchenmann kilchenmann

Labels
styling Update style; no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez