test (admin): adapt test for updateUserSystemAdminMembership (#138)

dasch-swiss · Feb 5, 2020 · 495fc66 · 495fc66
1 parent 4e53bce
commit 495fc66
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/api/admin/users/users-endpoint.spec.ts b/src/api/admin/users/users-endpoint.spec.ts
@@ -618,12 +618,7 @@ describe("UsersEndpoint", () => {
 
         it("should update a user's project admin membership", done => {
 
-            const storedUser = new StoredUser();
-
-            storedUser.id = "http://rdfh.ch/users/9XBCrDV3SRa7kS1WwynB4Q";
-            storedUser.systemAdmin = true;
-
-            knoraApiConnection.admin.usersEndpoint.updateUserSystemAdminMembership(storedUser).subscribe(
+            knoraApiConnection.admin.usersEndpoint.updateUserSystemAdminMembership("http://rdfh.ch/users/9XBCrDV3SRa7kS1WwynB4Q", true).subscribe(
                 (response: ApiResponseData<UserResponse> | ApiResponseError) => {
                 done();
             });

diff --git a/src/api/admin/users/users-endpoint.ts b/src/api/admin/users/users-endpoint.ts
@@ -7,7 +7,6 @@ import { Endpoint } from "../../endpoint";
 
 import { GroupsResponse } from "../../../models/admin/groups-response";
 import { ProjectsResponse } from "../../../models/admin/projects-response";
-import { StoredUser } from "../../../models/admin/stored-user";
 import { UpdateUserRequest } from "../../../models/admin/update-user-request";
 import { User } from "../../../models/admin/user";
 import { UserResponse } from "../../../models/admin/user-response";
@@ -274,11 +273,12 @@ export class UsersEndpoint extends Endpoint {
     /**
      * Updates a user's SystemAdmin membership.
      * 
-     * @param user The user to be updated.
+     * @param iri The IRI of the user to be updated.
+     * @param systemAdmin True if the user should be a system admin
      */
-    updateUserSystemAdminMembership(user: StoredUser): Observable<ApiResponseData<UserResponse> | ApiResponseError> {
+    updateUserSystemAdminMembership(iri: string, systemAdmin: boolean): Observable<ApiResponseData<UserResponse> | ApiResponseError> {
 
-        return this.httpPut("/iri/" + encodeURIComponent(user.id) + "/SystemAdmin", { systemAdmin: user.systemAdmin }).pipe(
+        return this.httpPut("/iri/" + encodeURIComponent(iri) + "/SystemAdmin", { systemAdmin: systemAdmin }).pipe(
             map(ajaxResponse => ApiResponseData.fromAjaxResponse(ajaxResponse, UserResponse, this.jsonConvert)),
             catchError(error => this.handleError(error))
         );
@@ -299,4 +299,4 @@ export class UsersEndpoint extends Endpoint {
 
     }
 
-}
+}