Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional caches #114

Closed
wants to merge 4 commits into from
Closed

Additional caches #114

wants to merge 4 commits into from

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Dec 2, 2019

  • get user by username
  • get project by shortcode
  • get project members by shortcode
  • get groups
  • get users

closes #106

@tobiasschweizer tobiasschweizer self-assigned this Dec 2, 2019
@tobiasschweizer tobiasschweizer added enhancement Improve existing code or new feature feature labels Dec 2, 2019
@tobiasschweizer
Copy link
Contributor Author

tobiasschweizer commented Dec 2, 2019

@kilchenmann I have just realized that the generic cache I wrote does not work for getting project members by project shortcode because the MembersResponse does not have an id.

Also I have realized that the generic cache requires an item to be identified by one id, but users and projects can be identified in three different ways. Of course we could have a separate cache for each way of getting a user, but there would be redundancy.

@kilchenmann
Copy link
Contributor

kilchenmann commented Dec 5, 2019

I have just realized that the generic cache I wrote does not work for getting project members by project shortcode because the MembersResponse does not have an id.

I handled it with a key for the cache like 'members_of_' + this.projectcode. But it's ok. I will optimize and use my generic cache service in the app itself. No problem...

@tobiasschweizer tobiasschweizer deleted the wip/106-caches branch April 16, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand cache services
2 participants