Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export mock factory and test data #125

Closed
wants to merge 30 commits into from
Closed

Conversation

tobiasschweizer
Copy link
Contributor

closes #121

@tobiasschweizer tobiasschweizer added the testing Testing of components of this lib label Dec 10, 2019
@tobiasschweizer tobiasschweizer self-assigned this Dec 10, 2019
@tobiasschweizer
Copy link
Contributor Author

tobiasschweizer commented Dec 10, 2019

It is possible to include mock factory methods and referenced test data in the package but this makes it heavy. Maybe there should be a dev version of the package and one for productive use.

@tobiasschweizer
Copy link
Contributor Author

@subotic This PR contains the necessary changes to produce a dev version of the package. I think I will be able to set up an automated publication process where:

  • a new productive build is published
  • the same version of the build is published with some additional code needed to generate test data

I think the convention could be that if "1.0.0-rc.0" is the productive version, "1.0.0-devrc.0" would be published in parallel (or "1.0.0" and "1.0.0-dev"). I think the dev version should always be treated as a prerelease.

However, I still need to make sure that it works correctly with semantic versioning.

@SepidehAlassi
Copy link
Contributor

@tobiasschweizer this branch is out-of-date. Can you please update it? or should I?

@tobiasschweizer
Copy link
Contributor Author

@tobiasschweizer this branch is out-of-date. Can you please update it? or should I?

This branch will be deleted, please use https://www.npmjs.com/package/@knora/api/v/1.0.0-rc.0
See dasch-swiss/dsp-ui-lib#76 (comment) for further details.

@tobiasschweizer tobiasschweizer deleted the wip/121-mock-factory branch May 13, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing of components of this lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockFactory needed for tests
3 participants