Skip to content

Commit

Permalink
chore: resolve CodeQL issues (DEV-2169) #371
Browse files Browse the repository at this point in the history
  • Loading branch information
jnussbaum committed May 17, 2023
1 parent 1764e81 commit 6822344
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions src/dsp_tools/fast_xmlupload/upload_files.py
Expand Up @@ -321,8 +321,6 @@ def upload_files(
Returns:
success status
"""
logger.info(f"***Call to upload_files(pkl_file='{pkl_file}', dir_with_processed_files='{dir_with_processed_files}', user='{user}',"
f"password='{password}', dsp_url='{dsp_url}', sipi_url='{sipi_url}')***")
# check the input parameters
param_check_result = _check_params(
pkl_file=pkl_file,
Expand Down
2 changes: 0 additions & 2 deletions src/dsp_tools/fast_xmlupload/upload_xml.py
Expand Up @@ -99,8 +99,6 @@ def fast_xmlupload(
Returns:
success status
"""
logger.info(f"***Call to fast_xml_upload(xml_file='{xml_file}', pkl_file='{pkl_file}', user='{user}',"
f"password='{password}', dsp_url='{dsp_url}', sipi_url='{sipi_url}')***")
xml_tree_orig = etree.parse(xml_file)
orig_path_2_uuid_filename = _get_paths_from_pkl_file(pkl_file=Path(pkl_file))
xml_tree_replaced = replace_bitstream_paths(xml_tree=xml_tree_orig, orig_path_2_uuid_filename=orig_path_2_uuid_filename)
Expand Down
2 changes: 1 addition & 1 deletion test/unittests/test_excel_to_json_resources.py
Expand Up @@ -123,7 +123,7 @@ def test_validate_resources_with_schema(self) -> None:
(
"testdata/invalid-testdata/excel2json/resources-invalid-cardinality.xlsx",
"did not pass validation. The problem is that the Excel sheet 'Owner' contains an invalid value "
"in row 3, column 'Cardinality': '0-2' is not one of ['1', '0-1', '1-n', '0-n']"
"in row 3, column 'Cardinality': '0-2' is not one of"
),
(
"testdata/invalid-testdata/excel2json/resources-invalid-property.xlsx",
Expand Down

0 comments on commit 6822344

Please sign in to comment.