Skip to content

Commit

Permalink
fix(xmlupload): don't loose elements when stashing standoff properties (
Browse files Browse the repository at this point in the history
  • Loading branch information
jnussbaum committed Mar 12, 2024
1 parent 3d5e071 commit c8e8966
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions src/dsp_tools/commands/xmlupload/stash/stash_models.py
Expand Up @@ -34,9 +34,14 @@ def make(items: list[StandoffStashItem]) -> StandoffStash | None:
Returns:
StandoffStash | None: A StandoffStash object or None, if an empty list was passed.
"""

def _get_res_id(x: StandoffStashItem) -> str:
return x.res_id

if not items:
return None
grouped_objects = {k: list(vals) for k, vals in groupby(items, key=lambda x: x.res_id)}
items = sorted(items, key=_get_res_id)
grouped_objects = {k: list(vals) for k, vals in groupby(items, key=_get_res_id)}
return StandoffStash(grouped_objects)


Expand Down Expand Up @@ -68,9 +73,14 @@ def make(items: list[LinkValueStashItem]) -> LinkValueStash | None:
Returns:
LinkValueStash | None: A LinkValueStash object or None, if an empty list was passed.
"""

def _get_res_id(x: LinkValueStashItem) -> str:
return x.res_id

if not items:
return None
grouped_objects = {k: list(vals) for k, vals in groupby(items, key=lambda x: x.res_id)}
items = sorted(items, key=_get_res_id)
grouped_objects = {k: list(vals) for k, vals in groupby(items, key=_get_res_id)}
return LinkValueStash(grouped_objects)


Expand Down

0 comments on commit c8e8966

Please sign in to comment.