Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(xmlupload): sanitize textvalues: remove whitespaces and newlines (D…
- Loading branch information
Showing
5 changed files
with
187 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import unittest | ||
|
|
||
| import pytest | ||
| from lxml import etree | ||
|
|
||
| from dsp_tools.models.xmlvalue import XMLValue | ||
|
|
||
|
|
||
| class TestXmlValue(unittest.TestCase): | ||
| """Test the XMLValue class""" | ||
|
|
||
| def test_cleanup_unformatted_text(self) -> None: | ||
| """Test the removal of whitespaces and line breaks in utf8-encoded text values""" | ||
| unformatted_text_orig = """<text permissions="prop-default" encoding="utf8"> | ||
| Poem | ||
| with 1 line break: | ||
| and 2 line breaks: | ||
| and 3 line breaks: | ||
| and multiple spaces and tabstops ... | ||
| and spaces on empty lines. | ||
| </text>""" | ||
| unformatted_text_expected = ( | ||
| "Poem" | ||
| "\n" | ||
| "with 1 line break:\n" | ||
| "and 2 line breaks:\n\n" | ||
| "and 3 line breaks:\n\n\n" | ||
| "and multiple spaces and tabstops ...\n\n" | ||
| "and spaces on empty lines." | ||
| ) | ||
| unformatted_node = etree.fromstring(unformatted_text_orig) | ||
| unformatted_xml_value = XMLValue(node=unformatted_node, val_type="text") | ||
| self.assertEqual(unformatted_xml_value.value, unformatted_text_expected) | ||
|
|
||
| def test_cleanup_formatted_text(self) -> None: | ||
| """Test the removal of whitespaces and line breaks in xml-formatted text values""" | ||
| formatted_text_orig = """<text permissions="prop-default" encoding="xml"> | ||
| This is <em>italicized and <strong>bold</strong></em> text! | ||
| It contains <code>monospace text that preserves whitespaces and & HTML-escapes</code>. | ||
| The same <pre>is true for preformatted text</pre>. | ||
| It contains multiple whitespaces and tabstops.<br/><br/> | ||
| Line breaks must be done with <code><br/></code> tags.<br/> | ||
| Otherwise they will be removed.<br/><br/> | ||
| It contains links to a resource: | ||
| <a class="salsah-link" href="IRI:test_thing_0:IRI">test_thing_0</a> | ||
| </text>""" | ||
| formatted_text_expected = ( | ||
| "This is <em>italicized and <strong>bold</strong></em> text! " | ||
| "It contains <code>monospace text that preserves whitespaces and & HTML-escapes</code>. " | ||
| "The same <pre>is true for preformatted text</pre>. " | ||
| "It contains multiple whitespaces and tabstops.<br/><br/>" | ||
| "Line breaks must be done with <code><br/></code> tags.<br/>" | ||
| "Otherwise they will be removed.<br/><br/>" | ||
| "It contains links to a resource: " | ||
| '<a class="salsah-link" href="IRI:test_thing_0:IRI">test_thing_0</a>' | ||
| ) | ||
| formatted_node = etree.fromstring(formatted_text_orig) | ||
| formatted_xml_value = XMLValue(node=formatted_node, val_type="text") | ||
| self.assertEqual(str(formatted_xml_value.value), formatted_text_expected) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| pytest.main([__file__]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters