New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: further refactoring of graph analysing #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some detail remarks
test/unittests/test_analyse_xml_data/test_construct_and_analyze_graph.py
Outdated
Show resolved
Hide resolved
testdata/xml-data/circular-references/analyse_circles_in_xml.py
Outdated
Show resolved
Hide resolved
This PR aims to improve readability, understandability, and maintainability of the graph analyzing. This comes with a small performance cost: With the big SGV XML file, the duration of the stashing deteriorated from ca. 1:20 min to ca. 1:45 min. But the stashing happens only once per xmlupload, so this is unproblematic. |
make_graph()
: 4th return element can be deduced from the other ones --> don't return it_remove_leaf_nodes()
: make a clear distinction betweennode_indices
andremaining_node_indices