Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: further refactoring of graph analysing #590

Merged
merged 19 commits into from Oct 25, 2023

Conversation

jnussbaum
Copy link
Collaborator

@jnussbaum jnussbaum commented Oct 24, 2023

  • make docstrings better understandable
  • make variable names better understandable
  • make_graph(): 4th return element can be deduced from the other ones --> don't return it
  • _remove_leaf_nodes(): make a clear distinction between node_indices and remaining_node_indices

@jnussbaum jnussbaum self-assigned this Oct 24, 2023
@jnussbaum jnussbaum changed the title refactor: refactor graph analysing, the second refactor: further refactoring of graph analysing Oct 24, 2023
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some detail remarks

@jnussbaum
Copy link
Collaborator Author

This PR aims to improve readability, understandability, and maintainability of the graph analyzing. This comes with a small performance cost: With the big SGV XML file, the duration of the stashing deteriorated from ca. 1:20 min to ca. 1:45 min. But the stashing happens only once per xmlupload, so this is unproblematic.

@jnussbaum jnussbaum merged commit d0779ac into main Oct 25, 2023
8 checks passed
@jnussbaum jnussbaum deleted the wip/refactor-graph-analysing-2 branch October 25, 2023 14:01
@daschbot daschbot mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants