-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use class Edge instead of complicated type annotation #591
refactor: use class Edge instead of complicated type annotation #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally like the changes. How confident are you that this does not have a negative performance impact for large datasets?
How could it have a negative impact? I didn't think about it, but I cannot think of a way how it impacts performance negatively. |
Just one example that struck my eye:
This loop was previously not needed, now it's there. And maybe there is more like that, I did not search systematically. If it adds up to some seconds for a big upload, we don't need to care... but it would be good to be sure. Could you compare how long the graph analysis routine takes on the SGV XML, between the current main branch and yours with all the changes. Then we don't need to guess/hope, but simply know it. |
The complicated type annotation
list[tuple[int, int, XMLLink | ResptrLink]]
is replaced by a new model:class Edge
inmodels.py