chore(project-create): clean up one ruff PLR0912 and one PLR0913 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nora-Olivia-Ammann
changed the title
Nora-Olivia-Ammann
changed the title
jnussbaum
approved these changes
Jan 30, 2024
Nora-Olivia-Ammann
deleted the
wip/chore(project-create)-clean-up-ruff-PLR0912
branch
Merged
jnussbaum
reviewed
Jan 30, 2024
|
|
||
|
|
||
| def _get_all_lists(project_json: dict[str, Any]) -> list[dict[str, Any]] | None: | ||
| # expand the Excel files referenced in the "lists" section of the project (if any), and add them to the project |
There was a problem hiding this comment.
This comment is not true any more: the expanded lists are not added to the parsed JSON project any more (which is fine, but the comment should be updated)
There was a problem hiding this comment.
I will do it in the next PR (it is also cleaning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.