-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(project-create): clean up one ruff PLR0912 and one PLR0913 #772
chore(project-create): clean up one ruff PLR0912 and one PLR0913 #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitively an improvement, LGTM.
I have made some comments how you could even further improve it.
|
||
|
||
def _get_all_lists(project_json: dict[str, Any]) -> list[dict[str, Any]] | None: | ||
# expand the Excel files referenced in the "lists" section of the project (if any), and add them to the project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is not true any more: the expanded lists are not added to the parsed JSON project any more (which is fine, but the comment should be updated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do it in the next PR (it is also cleaning)
No description provided.