Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(excel2json): add optional column "subject" to properties.xlsx (DEV-3253) #777

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Jan 31, 2024
Copy link

linear bot commented Jan 31, 2024

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title feat(excel2json): add subjectClassConstraint option to properties feat(excel2json): add subjectClassConstraint option to properties (DEV-3253) Jan 31, 2024
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

src/dsp_tools/commands/excel2json/properties.py Outdated Show resolved Hide resolved
test/unittests/commands/excel2json/test_properties.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title feat(excel2json): add subjectClassConstraint option to properties (DEV-3253) feat(excel2json): add optional subject excel column to properties (DEV-3253) Jan 31, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title feat(excel2json): add optional subject excel column to properties (DEV-3253) feat(excel2json): add optional subject excel-column to properties (DEV-3253) Jan 31, 2024
@jnussbaum jnussbaum changed the title feat(excel2json): add optional subject excel-column to properties (DEV-3253) feat(excel2json): add optional column "subject" to properties.xlsx (DEV-3253) Jan 31, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit cf491e9 into main Jan 31, 2024
13 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3253-add-subjectClassConstraint-support-to-excel2json branch January 31, 2024 13:22
@daschbot daschbot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants