-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(excel2json): add optional column "subject" to properties.xlsx (DEV-3253) #777
Merged
Nora-Olivia-Ammann
merged 11 commits into
main
from
wip/dev-3253-add-subjectClassConstraint-support-to-excel2json
Jan 31, 2024
Merged
feat(excel2json): add optional column "subject" to properties.xlsx (DEV-3253) #777
Nora-Olivia-Ammann
merged 11 commits into
main
from
wip/dev-3253-add-subjectClassConstraint-support-to-excel2json
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nora-Olivia-Ammann
changed the title
feat(excel2json): add subjectClassConstraint option to properties
feat(excel2json): add subjectClassConstraint option to properties (DEV-3253)
Jan 31, 2024
…ort-to-excel2json
…l2json' of https://github.com/dasch-swiss/dsp-tools into wip/dev-3253-add-subjectClassConstraint-support-to-excel2json
jnussbaum
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments
docs/assets/data_model_templates/rosetta (rosetta)/properties.xlsx
Outdated
Show resolved
Hide resolved
Nora-Olivia-Ammann
changed the title
feat(excel2json): add subjectClassConstraint option to properties (DEV-3253)
feat(excel2json): add optional subject excel column to properties (DEV-3253)
Jan 31, 2024
jnussbaum
reviewed
Jan 31, 2024
jnussbaum
reviewed
Jan 31, 2024
testdata/excel2json/excel2json_files/test-name (test_label)/properties.xlsx
Outdated
Show resolved
Hide resolved
Nora-Olivia-Ammann
changed the title
feat(excel2json): add optional subject excel column to properties (DEV-3253)
feat(excel2json): add optional subject excel-column to properties (DEV-3253)
Jan 31, 2024
jnussbaum
changed the title
feat(excel2json): add optional subject excel-column to properties (DEV-3253)
feat(excel2json): add optional column "subject" to properties.xlsx (DEV-3253)
Jan 31, 2024
jnussbaum
approved these changes
Jan 31, 2024
Nora-Olivia-Ammann
deleted the
wip/dev-3253-add-subjectClassConstraint-support-to-excel2json
branch
January 31, 2024 13:22
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.