New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add module csv2xml to convert tabular data to DSP-XML (DEV-134) #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall certainly a great improvement to DSP-Tools.
I ended up with quite a number of comments - but not all of them are equally relevant.
I understand if you don't want to drag out that PR forever, so feel free to apply/ignore as much as you feel is right. But I really don't think any file should be 2k+ lines, so I'd like to see that broken up, if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have the feeling that the module is very hard to use for a custom user who does not do this work regularly. But I guess you clarified the use and need of this module beforehand?
use uuid instead of hash
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
resolves DEV-134