Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xmlupload): enable migration of resource creation date (DEV-1402) #238

Merged
merged 24 commits into from Oct 18, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1402

@jnussbaum jnussbaum self-assigned this Oct 7, 2022
knora/dsplib/models/resource.py Outdated Show resolved Hide resolved
testdata/test-data-systematic.xml Outdated Show resolved Hide resolved
knora/dsplib/schemas/data.xsd Outdated Show resolved Hide resolved
@@ -63,7 +62,7 @@ def __str__(self) -> str:
Convert to string
:return: stringyfied error message
"""
return self._message + "\n\n" + format_exc()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a clue what format_exc() was good for in the past, but I know that it causes problems. It was the source of this strange behaviour that I already had in the past: when a BaseError occurs while testing, Python prints an infinitely long stacktrace full of riddles, and then crashes.

I found out that I can just remove format_exc()

@jnussbaum jnussbaum requested review from irinaschubert and BalduinLandolt and removed request for BalduinLandolt October 13, 2022 09:22
Makefile Show resolved Hide resolved
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor improvement suggestions

docs/dsp-tools-excel.md Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
knora/dsplib/utils/validation.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
knora/dsplib/utils/validation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Makefile Show resolved Hide resolved
knora/dsplib/models/helpers.py Show resolved Hide resolved
knora/dsplib/models/resource.py Outdated Show resolved Hide resolved
knora/dsplib/utils/validation.py Outdated Show resolved Hide resolved
knora/dsplib/utils/validation.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Show resolved Hide resolved
knora/excel2xml.py Outdated Show resolved Hide resolved
@jnussbaum jnussbaum changed the title feat(xmlupload): support migration of resource creation date (DEV-1402) feat(xmlupload): enable migration of resource creation date (DEV-1402) Oct 18, 2022
@jnussbaum jnussbaum merged commit 83dd2de into main Oct 18, 2022
5 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1402-add-resource-creation-date-in-xml branch October 18, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants