Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs in json schema (DEV-1142) #252

merged 11 commits into from Nov 11, 2022


Copy link

resolves DEV-1142


 - define super-resource in a non-recurring way
 - URI as "super" of a resource
 - properties.xlsx: hasLinkTo: Resource, Region, StillImageRepresentation, AudioRepresentation, MovingImageRepresentation, ArchiveRepresentation
- remove excelfileref
- disallow nested excelfileref: must be on top hierarchy level
@jnussbaum jnussbaum self-assigned this Nov 10, 2022
Copy link
Collaborator Author

In this PR, I (exceptionally) managed to make meaningful commits. It probably makes reviewing easier if you go through the commits one after the other.

Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an easy PR to review, but from what I saw, it seems to make sense

@jnussbaum jnussbaum merged commit 92af830 into main Nov 11, 2022
4 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1142-bugs-in-json-schema branch November 11, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants