Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix bandit: always exit with 0 (DEV-2536) #476

Merged
merged 1 commit into from
Aug 21, 2023
Merged

chore: fix bandit: always exit with 0 (DEV-2536) #476

merged 1 commit into from
Aug 21, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Aug 21, 2023
@linear
Copy link

linear bot commented Aug 21, 2023

DEV-2536 fix bandit workflow configuration

Configuration of the bandit workflow must be improved:

  • The bandit workflow doesn't upload its results (sarif file), so they aren't visible in the "Security" tab of the dsp-tools repo.
  • There are too many false positives
  • The workflow uses an outdated version of the "checkout" action.

@jnussbaum jnussbaum merged commit c5351b4 into main Aug 21, 2023
4 checks passed
@jnussbaum jnussbaum deleted the wip/fix-bandit-exit-0 branch August 21, 2023 10:25
@daschbot daschbot mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jnussbaum