Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --dump flag to "xmlupload" and "get" commands (DEV-2534) #502

Merged
merged 3 commits into from Sep 1, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Sep 1, 2023
@jnussbaum jnussbaum changed the title feat: add --dump flag to "xmlupload" and "get" commands feat: add --dump flag to "xmlupload" and "get" commands (DEV-2534) Sep 1, 2023
@linear
Copy link

linear bot commented Sep 1, 2023

DEV-2534 add --dump flag to "xmlupload" and "get" commands, improve dumping mechanism

The initial intent of this PR was to start refactoring the "models". I started with connection.py and sipi.py.

In the end I not just rewrote these 2 classes in a more elegant way, but I also improved their dumping mechanism. And now that we have a good dumping mechanism, why not add a --dump flag to the commands xmlupload and get?

@jnussbaum jnussbaum merged commit d9aeba9 into main Sep 1, 2023
4 of 5 checks passed
@jnussbaum jnussbaum deleted the wip/add-dump-flag branch September 1, 2023 13:06
@daschbot daschbot mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant