Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xmlupload): print reason of failure if resource cannot be created (DEV-2925) #637

Merged

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Nov 14, 2023

DEV-2925 xmlupload: reason of failure is not printed

Error handling of resource creation is suboptimal: If DSP-API refuses to create a resource, the user doesn’t see the reason, i.e. the original message from DSP-API. Previously, this was the case, and it was very helpful.

Current output:

WARNING: Unable to create resource 'First Testthing' (test_thing_1): Could not create resource test_thing_1 (label: First Testthing, iri: None)

Future output (with the changes of this PR):

WARNING: Unable to create resource 'First Testthing' (test_thing_1): Resource class <http://0.0.0.0:3333/ontology/4123/testonto/v2#TestThing> has no cardinality for property <http://www.knora.org/ontology/4123/testonto#hasRichtextt>

@jnussbaum jnussbaum changed the title fix(xmlupload): print reason of failure if resource cannot be resolved (DEV-2925) fix(xmlupload): print reason of failure if resource cannot be created (DEV-2925) Nov 14, 2023
@jnussbaum jnussbaum self-assigned this Nov 14, 2023
@jnussbaum jnussbaum enabled auto-merge (squash) November 14, 2023 10:35
@jnussbaum jnussbaum merged commit e3a194a into main Nov 14, 2023
8 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-2925-xmlupload-reason-of-failure-is-not-printed branch November 14, 2023 12:21
@daschbot daschbot mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants