Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(excel2xml): make_text_prop: allow <, >, & in rich texts (DEV-3131) #691

Merged
merged 23 commits into from
Dec 29, 2023
Merged

fix(excel2xml): make_text_prop: allow <, >, & in rich texts (DEV-3131) #691

merged 23 commits into from
Dec 29, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Dec 18, 2023
@linear Linear
Copy link

linear bot commented Dec 18, 2023

DEV-3131 fix(excel2xml): make_text_prop: allow <, >, & for rich texts

@jnussbaum jnussbaum changed the title fix(excel2xml): make_text_prop: allow <, >, & for rich texts (DEV-3131) fix(excel2xml): make_text_prop: allow <, >, & in rich texts (DEV-3131) Dec 19, 2023
BalduinLandolt
BalduinLandolt approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you can find a more readable solution for the regex, I'd be happy; if not, that's ok too

src/dsp_tools/commands/excel2xml/excel2xml_lib.py Show resolved Hide resolved
test/unittests/commands/excel2xml/test_excel2xml_lib.py Outdated Show resolved Hide resolved
test/unittests/commands/excel2xml/test_excel2xml_lib.py Outdated Show resolved Hide resolved
test/unittests/commands/excel2xml/test_excel2xml_lib.py Outdated Show resolved Hide resolved
@jnussbaum jnussbaum enabled auto-merge (squash) December 29, 2023 08:18
@jnussbaum jnussbaum merged commit 228c79f into main Dec 29, 2023
9 checks passed
@jnussbaum jnussbaum deleted the wip/special-chars-make_text_prop branch December 29, 2023 08:21
@daschbot daschbot mentioned this pull request Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnussbaum @BalduinLandolt @Nora-Olivia-Ammann