Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add PermanentConnectionError to make BaseError slimmer (DEV-3192) #741

Merged
merged 30 commits into from
Jan 18, 2024
Merged

chore: add PermanentConnectionError to make BaseError slimmer (DEV-3192) #741

merged 30 commits into from
Jan 18, 2024

Commits on Jan 16, 2024

  1. separate PermanentConnectionError from BaseError

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    fc086f8 View commit details
    Browse the repository at this point in the history

  2. tidy up PermanentConnectionError and BaseError

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    bafb5aa View commit details
    Browse the repository at this point in the history

  3. tidy up usages of BaseError

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f30d454 View commit details
    Browse the repository at this point in the history

  4. working version?

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e6e2e1e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into wip/fix-request-logging

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f6083a4 View commit details
    Browse the repository at this point in the history

  6. beautify diff

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f5c978e View commit details
    Browse the repository at this point in the history

  7. fix e2e

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d632381 View commit details
    Browse the repository at this point in the history

  8. edit

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b1cb58d View commit details
    Browse the repository at this point in the history

  9. fix docstring

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8900253 View commit details
    Browse the repository at this point in the history

  10. refactor _try_network_action

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f8a6a1b View commit details
    Browse the repository at this point in the history

  11. fix darglint

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    dc814d9 View commit details
    Browse the repository at this point in the history

  12. _log_response(): log status code; make serialization clearer

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ed3c735 View commit details
    Browse the repository at this point in the history

  13. distinguish messages

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4de415f View commit details
    Browse the repository at this point in the history

  14. edit

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    47917a7 View commit details
    Browse the repository at this point in the history

  15. fix: if session is reset, it needs the token

    @jnussbaum
    jnussbaum committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8b5f528 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. add _anonymize() method

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b69ba76 View commit details
    Browse the repository at this point in the history

  2. improve content logging of response

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ad00309 View commit details
    Browse the repository at this point in the history

  3. temporarily use builtin logging

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b5dd4f3 View commit details
    Browse the repository at this point in the history

  4. don't print/log before raising PermanentConnectionError

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b609aa0 View commit details
    Browse the repository at this point in the history

  5. Revert "temporarily use builtin logging" 

    This reverts commit b5dd4f3.
    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bc1c318 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into wip/fix-request-logging

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8990651 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into wip/fix-request-logging

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0d260fb View commit details
    Browse the repository at this point in the history

  8. clean up merge conflicts

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a40a69a View commit details
    Browse the repository at this point in the history

  9. remove unnecessary fields

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b3aad00 View commit details
    Browse the repository at this point in the history

  10. revert unwanted changes

    @jnussbaum
    jnussbaum committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    848fc9c View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. test for error type, not for message

    @jnussbaum
    jnussbaum committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d32a326 View commit details
    Browse the repository at this point in the history

  2. be more precise in docstrings

    @jnussbaum
    jnussbaum committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    88d0704 View commit details
    Browse the repository at this point in the history

  3. - don't log pw when login fails 

    - print useful error msg if login fails
    @jnussbaum
    jnussbaum committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b6fa4e6 View commit details
    Browse the repository at this point in the history

  4. fix

    @jnussbaum
    jnussbaum committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7689bf3 View commit details
    Browse the repository at this point in the history

  5. explicit exception chaining: better link between the two tracebacks i… 

    …n the final error
    @jnussbaum
    jnussbaum committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    142f6c0 View commit details
    Browse the repository at this point in the history