Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project_validate): fix one ruff PLR0912 #781

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/dsp_tools/commands/project/create/project_validate.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,23 @@ def _check_for_duplicate_names(project_definition: dict[str, Any]) -> bool:
Returns:
True if the resource/property names are unique
"""
propnames_duplicates, resnames_duplicates = _find_duplicates(project_definition)

if not resnames_duplicates and not propnames_duplicates:
return True

err_msg = "Resource names and property names must be unique inside every ontology.\n"
for ontoname, res_duplicates in resnames_duplicates.items():
for res_duplicate in sorted(res_duplicates):
err_msg += f"Resource '{res_duplicate}' appears multiple times in the ontology '{ontoname}'.\n"
for ontoname, prop_duplicates in propnames_duplicates.items():
for prop_duplicate in sorted(prop_duplicates):
err_msg += f"Property '{prop_duplicate}' appears multiple times in the ontology '{ontoname}'.\n"

raise BaseError(err_msg)


def _find_duplicates(project_definition: dict[str, Any]) -> tuple[dict[str, set[str]], dict[str, set[str]]]:
resnames_duplicates: dict[str, set[str]] = {}
propnames_duplicates: dict[str, set[str]] = {}
for onto in project_definition["project"]["ontologies"]:
Expand All @@ -46,19 +63,7 @@ def _check_for_duplicate_names(project_definition: dict[str, Any]) -> bool:
propnames_duplicates[onto["name"]].add(elem)
else:
propnames_duplicates[onto["name"]] = {elem}

if not resnames_duplicates and not propnames_duplicates:
return True

err_msg = "Resource names and property names must be unique inside every ontology.\n"
for ontoname, res_duplicates in resnames_duplicates.items():
for res_duplicate in sorted(res_duplicates):
err_msg += f"Resource '{res_duplicate}' appears multiple times in the ontology '{ontoname}'.\n"
for ontoname, prop_duplicates in propnames_duplicates.items():
for prop_duplicate in sorted(prop_duplicates):
err_msg += f"Property '{prop_duplicate}' appears multiple times in the ontology '{ontoname}'.\n"

raise BaseError(err_msg)
return propnames_duplicates, resnames_duplicates


def _check_for_undefined_super_resource(project_definition: dict[str, Any]) -> bool:
Expand Down