feat: Add interrupt-after to xmlupload and resume-xmlupload (DEV-3390)
#862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
changed the base branch from
main
to
wip/DEV-3323-resume-an-interrupted-xmlupload
…ure/dev-3390-add-batching-to-xml-upload-and-resume
jnussbaum
reviewed
Mar 7, 2024
Comment on lines
414
to
415
| if i >= interrupt_after: | ||
| raise KeyboardInterrupt(f"Interrupted: Maximum number of resources was reached ({interrupt_after})") |
There was a problem hiding this comment.
EDIT: i think these lines should be at the very beginning of the for loop, i.e. on line 405
…ure/dev-3390-add-batching-to-xml-upload-and-resume
jnussbaum
merged commit 753a5fe
into
wip/DEV-3323-resume-an-interrupted-xmlupload
8 checks passed
jnussbaum
deleted the
feature/dev-3390-add-batching-to-xml-upload-and-resume
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.