Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xmlupload): don't stop xmlupload when resource is wrong (DEV-3419) #880

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Mar 13, 2024
Copy link

linear bot commented Mar 13, 2024

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title fix(xmlupload): make so that xmlupload doesn't stop when resource is wrong fix(xmlupload): make so that xmlupload doesn't stop when resource is wrong (DEV-3419) Mar 13, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann requested review from jnussbaum and BalduinLandolt and removed request for jnussbaum March 13, 2024 15:01
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit-pick: could you change the PR title?

- make so that xmlupload doesn't stop when resource is wrong
+ don't stop xmlupload when resource is wrong

I find make so that XYZ doesn't XYZ a bit clunky

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(meant to click "approve" the first time ^^)

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title fix(xmlupload): make so that xmlupload doesn't stop when resource is wrong (DEV-3419) fix(xmlupload): don't stop xmlupload when resource is wrong (DEV-3419) Mar 13, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 86795ec into main Mar 13, 2024
11 of 12 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3419-fix-connection-error-raised-when-resource-is-wrong branch March 13, 2024 15:37
@daschbot daschbot mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants