Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix ruff format checking #915

Merged
merged 3 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests-on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: ./.github/actions/setup
- name: Linting with ruff
run: poetry exec ruff-check-github
- name: Formatting with ruff
- name: Check formatting with ruff
run: poetry exec ruff-format
- name: Linting with mypy
run: poetry exec mypy
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ ruff-check = "ruff check . --ignore=A002,D101,D102,PLR0913,PLR2004,PLW0603"
ruff-check-github = """
ruff check . --output-format=github --ignore=A002,D101,D102,PLR0913,PLR2004,PLW0603
"""
ruff-format = "ruff format ."
ruff-format = "ruff format --check ."
mypy = "mypy ."
unittests = "pytest test/unittests/"
integration-tests = "pytest test/integration/"
Expand Down
6 changes: 2 additions & 4 deletions src/dsp_tools/commands/excel2xml/excel2xml_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -524,12 +524,10 @@ def excel2xml(
print(f"WARNING: {warning.message}")

if success:
print(f"XML file successfully written to '{output_file!s}'")
print(f"XML file successfully written to '{output_file}'")
else:
red = "\033[31m"
end = "\033[0m"
print(
f"{red}Some problems occurred. The XML file was written to '{output_file!s}', but it might be corrupt{end}"
)
print(f"{red}Some problems occurred. The XML file was written to '{output_file}', but it might be corrupt{end}")

return success, catched_warnings