Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Sort Button #101

Merged
merged 1 commit into from Jun 9, 2020
Merged

Refactor Sort Button #101

merged 1 commit into from Jun 9, 2020

Conversation

mdelez
Copy link
Contributor

@mdelez mdelez commented Jun 9, 2020

@mdelez
refactor (sort-button): removed sortKey input since it was used for t…
578f70d 
…wo-way binding in the template. We now use a service called from the class to sort
@mdelez mdelez added the refactor label Jun 9, 2020
@mdelez mdelez self-assigned this Jun 9, 2020
tobiasschweizer
tobiasschweizer approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles like a charm now!

@tobiasschweizer tobiasschweizer mentioned this pull request Jun 9, 2020
Merged
@mdelez mdelez merged commit 13b5126 into master Jun 9, 2020
@mdelez mdelez deleted the wip/DSP-337-refactor-sort-button branch June 9, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

@kilchenmann kilchenmann Awaiting requested review from kilchenmann

Assignees

@mdelez mdelez

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @tobiasschweizer