Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP-649 Hide Geometry Property #187

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Conversation

mdelez
Copy link
Contributor

@mdelez mdelez commented Sep 23, 2020

closes https://dasch.myjetbrains.com/youtrack/issue/DSP-649

uses dsp-js rc.11 and dsp-api rc.15

@mdelez mdelez self-assigned this Sep 23, 2020
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

this.resPropInfoVals.sort((a, b) => (a.guiDef.guiOrder > b.guiDef.guiOrder) ? 1 : -1);
this.resPropInfoVals =
this.resPropInfoVals
.filter(prop => prop.propDef.objectType !== 'http://api.knora.org/ontology/knora-api/v2#GeomValue')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a constant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constant added in 49f6602

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neater

@mdelez
Copy link
Contributor Author

mdelez commented Sep 23, 2020

neater

That's pretty neat

@mdelez mdelez merged commit fa93c70 into master Sep 23, 2020
@mdelez mdelez deleted the wip/dsp-649-hide-geometry-property branch September 23, 2020 14:15
@kilchenmann kilchenmann changed the title Hide Geometry Property DSP-649 Hide Geometry Property Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants