Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSP-653 Default Boolean Value #192

Merged
merged 2 commits into from
Sep 24, 2020
Merged

DSP-653 Default Boolean Value #192

merged 2 commits into from
Sep 24, 2020

Conversation

mdelez
Copy link
Contributor

@mdelez mdelez commented Sep 23, 2020

closes https://dasch.myjetbrains.com/youtrack/issue/DSP-653

uses dsp-js rc.11 and dsp-api rc.15

@mdelez mdelez added enhancement New feature or request refactor labels Sep 23, 2020
@mdelez mdelez self-assigned this Sep 23, 2020
@tobiasschweizer

This comment has been minimized.

Sign in to view
@tobiasschweizer
Copy link
Contributor

I think it doesn't matter since it will be overwritten by resetFormControl.

tobiasschweizer
tobiasschweizer approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense :-)

@mdelez mdelez merged commit 6128558 into master Sep 24, 2020
@mdelez mdelez deleted the wip/dsp-653-default-boolean-value branch September 24, 2020 10:09
@kilchenmann kilchenmann changed the title Default Boolean Value DSP-653 Default Boolean Value Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees

@mdelez mdelez

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @tobiasschweizer