Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing decorator to ValueOperationEventService #232

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

tobiasschweizer
Copy link
Contributor

This PRs adds the missing decorator to ValueOperationEventService.

https://angular.io/api/core/Injectable#usage-notes:

Marking a class with @Injectable ensures that the compiler will generate the necessary metadata to create the class's dependencies when the class is injected.

@tobiasschweizer tobiasschweizer added the enhancement New feature or request label Nov 19, 2020
@tobiasschweizer tobiasschweizer self-assigned this Nov 19, 2020
@@ -9,6 +10,7 @@ import { filter, map } from 'rxjs/operators';
* The ValueOperationEventService essentially creates a direct communication channel between
* the emitting component and the listening component.
*/
@Injectable() // must be provided on component level, i.d. resource view component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.d. -> i.e. ?

@mdelez mdelez self-requested a review November 19, 2020 12:45
@tobiasschweizer tobiasschweizer merged commit fbb655e into main Nov 19, 2020
@tobiasschweizer tobiasschweizer deleted the wip/service-decorator branch November 19, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants