DSP-974 / DSP-1043 Determine from ontology if a property is read-only #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasschweizer
added
breaking
mdelez
reviewed
Nov 20, 2020
| addButtons = propertyViewComponentDe.queryAll(By.css('button.create')); | ||
| expect(addButtons.length).toEqual(20); | ||
| expect(addButtons.length).toEqual(18); |
There was a problem hiding this comment.
Is there a better way to know the number of expected buttons than to write a hardcoded number? Maybe we can use the propArray to check how many properties are not read-only and use that? This way if the test data changes, we don't have to keep manually updating the number. Idk how it will work with cardinalities though.
There was a problem hiding this comment.
I added some explicit tests in 186d024
added 4 commits
November 23, 2020 10:08
flavens
approved these changes
Nov 23, 2020
kilchenmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-974 and DSP-1043
ValueService.isReadOnlyhas an additional third argument now:propertyDef: ResourcePropertyDefinition.I added the flag "breaking" because this method could be used directly by the app.