Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update constants (DSP-1187) #263

Merged
merged 3 commits into from Jan 21, 2021
Merged

refactor: update constants (DSP-1187) #263

merged 3 commits into from Jan 21, 2021

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Jan 21, 2021

resolves DSP-1187

@mpro7 mpro7 added the refactor label Jan 21, 2021
@mpro7 mpro7 self-assigned this Jan 21, 2021
@mpro7 mpro7 changed the title refactor: update constants refactor: update constants (DSP-1187) Jan 21, 2021
mdelez
mdelez approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for bumping the DSP-JS version as well!

@mpro7 mpro7 merged commit 1c12912 into main Jan 21, 2021
@mpro7 mpro7 deleted the wip/DSP-1187-update-constants branch January 21, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

@kilchenmann kilchenmann Awaiting requested review from kilchenmann

Assignees

@mpro7 mpro7

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpro7 @mdelez