Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt parsing of an ontology's lastModificationDate #58

Merged
merged 20 commits into from Jan 21, 2020

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Sep 24, 2019

This PR adapts the parsing of an ontology's lastModificationDate.

closes #47
relates to dasch-swiss/dsp-api#1442

@tobiasschweizer
Copy link
Contributor Author

This PR can be merged once dasch-swiss/dsp-api#1442 has been merged.

@tobiasschweizer
Copy link
Contributor Author

Remove -b wip/1439-last-modification-date from travis.yml before merging.

@tobiasschweizer
Copy link
Contributor Author

@benjamingeer Once #115 is merged and this PR is up to date, it is ready to be merged in coordination with dasch-swiss/dsp-api#1442

Tobias Schweizer and others added 4 commits December 12, 2019 15:01
# Conflicts:
#	src/models/v2/custom-converters/date-time-stamp-converter.ts
#	test/data/api/v2/ontologies/all-ontology-metadata-expanded.json
#	test/data/api/v2/ontologies/all-ontology-metadata.json
#	test/data/api/v2/ontologies/anything-ontology-expanded.json
@tobiasschweizer
Copy link
Contributor Author

@benjamingeer ab57339 uses Knora develop which will make the E2E tests fail until dasch-swiss/dsp-api#1442 is merged.

Copy link
Contributor

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@tobiasschweizer
Copy link
Contributor Author

Ok, I restarted the tests. The e2e tests should now pass with the updated Knora develop.

@tobiasschweizer
Copy link
Contributor Author

ok, they e2e tests passed. Just waiting for the process to finish ...

@tobiasschweizer
Copy link
Contributor Author

and möööööööörtsch

@tobiasschweizer tobiasschweizer merged commit 324b84f into master Jan 21, 2020
@tobiasschweizer tobiasschweizer deleted the wip/47-modification-date branch January 21, 2020 15:01
@daschbot
Copy link
Collaborator

This pull request has been mentioned on Discuss DaSCH. There might be relevant details there:

https://discuss.dasch.swiss/t/knora-v12-0-0-released/139/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in format of knora-api:lastModificationDate
3 participants