feat: Upgrade sipi to 2.0.1

[subotic]

resolves #1437
resolves #1449
resolves #1457
resolves #1472

[benjamingeer]

The URL of the IIIF images is hardcoded in a JSON file

Where is that file?

[subotic]

The URL of the IIIF images is hardcoded in a JSON file

Where is that file?

in ResourcesResponderV1SpecContextData line 43: src/test/resources/test-data/v1/expectedBookContextResponse.json

[benjamingeer]

in ResourcesResponderV1SpecContextData line 43: src/test/resources/test-data/v1/expectedBookContextResponse.json

OK, I understand now. But that's an important test, we shouldn't disable it. You could turn the JSON file into a template, e.g. replace all 0.0.0.0:1024 with SIPI_HOST. Then in the test, when the file is loaded, replace SIPI_HOST with the configured value.

[subotic]

Would be great :-)

[benjamingeer]

I mean, just use String.replaceAll(), it will just be one line of code.

[subotic]

I mean, just use String.replaceAll(), it will just be one line of code.

done in e7f47f6. added the test back.

[subotic]

@benjamingeer could you take a quick look?

[benjamingeer]

Looks OK but something isn't working in the build, and I keep getting emails from Codacy saying that there are issues.

[subotic]

yes, I've renamed some makefile targets and forgot to update .travis.yml. Doing it now.

[subotic]

should be fixed now.

Regarding Codacy, I don't have access to the 'dasch-swiss' organization.

[benjamingeer]

Regarding Codacy, I don't have access to the 'dasch-swiss' organization.

I don't understand much about Codacy, but for me it displays this PR under dhlab-basel:

[subotic]

ah, makes sense. I will change it.

[benjamingeer]

This looks good to me. If it's done, please merge and many thanks!

[subotic]

your welcome and thanks for the review :-)