Uri Value Component

[mdelez]

closes #17

[tobiasschweizer]

Thanks, I try to have a look at that today.

[mdelez]

I think the validator could use some work but I'm not entirely sure what Knora accepts as a valid url

[tobiasschweizer]

I think the validator could use some work but I'm not entirely sure what Knora accepts as a valid url

any valid xsd:URI (https://docs.knora.org/paradox/02-knora-ontologies/knora-base.html#subclasses-of-value, https://github.com/dasch-swiss/knora-api/blob/ccb64bbcf16b80d55423ff44b28c89d34bf39581/webapi/src/main/scala/org/knora/webapi/util/StringFormatter.scala#L713-L714).

I think it would be a good idea to put the validators in a central place so they could be reused. Also then the regex would only be created once and not with every instance of a value component.

[mdelez]

any valid xsd:URI (https://docs.knora.org/paradox/02-knora-ontologies/knora-base.html#subclasses-of-value, https://github.com/dasch-swiss/knora-api/blob/ccb64bbcf16b80d55423ff44b28c89d34bf39581/webapi/src/main/scala/org/knora/webapi/util/StringFormatter.scala#L713-L714).

I'm a little lost on how I can use this. Do we have validation functions set up already for uri's or will we still need to use regex?

I think it would be a good idea to put the validators in a central place so they could be reused. Also then the regex would only be created once and not with every instance of a value component.

I can work on this. It would probably be good to implement it before we create all of the other components. Should I make a new issue for this?

[tobiasschweizer]

Could you adapt the variable name? Just for reasons of clarity, doesn't make any technical difference.

[mdelez]

done in b228083

[tobiasschweizer]

please adapt the test's name

[mdelez]

done in b228083

[tobiasschweizer]

Looks good, thanks!