Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing validation on missing referenced exporters, receivers, processors, extensions #90

Closed
bripkens opened this issue Oct 4, 2023 · 7 comments
Assignees

Comments

@bripkens
Copy link
Member

bripkens commented Oct 4, 2023

The pipelines may be referencing components that do not exist, and OtelBin is not raising those as issues. in the screenshot, the health_check/i_do_not_exist extension is not declared (only heath_check is), so this configuration is invalid. The same applies with, for example, a traces pipeline referencing an extension that is not declared in the extensions list.

@bripkens bripkens added this to the iteration-1 milestone Oct 4, 2023
@bripkens
Copy link
Member Author

@mmanciop: This is now deployed, do you also wanna give this a test? :)

@mmanciop
Copy link
Member

Screenshot 2023-10-10 at 17 48 03 I like what the editor does, I just that the pipelines would still be visible, and the reference to the missing component would be highlighted with some question mark or so.

@roshan-gh
Copy link
Contributor

@mmanciop the pipeline is still visible with warnings, but with errors it's not visible. Doesn't it make sense this way?

@mmanciop
Copy link
Member

It depends on the nature of the error. YAML is broken -> cannot visualize. Config references some stuff that does not exist -> makes perfect sense to show from where you are referencing the stuff that does not exist, because where it is referenced from is important context to under whether you fix the config by adding the missing component, because you need it, or you delete the dangling reference.

@roshan-gh
Copy link
Contributor

It makes sense, right. Then I will change the codes to have the visualization with custom errors+warnings. @mmanciop @bripkens

@roshan-gh
Copy link
Contributor

Fixed it in change cursor to pipeline/definitions PR @mmanciop @bripkens

@bripkens bripkens removed this from the iteration-1 🚀 milestone Nov 2, 2023
@mmanciop
Copy link
Member

mmanciop commented Nov 2, 2023

Subsumed in #94

@mmanciop mmanciop closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants