Handle messages without data #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages with payloadFormat: "NONE" may not contain the data attribute. Note something may have changed on Google's side because I belive this was previously handled by the nil check. Closes #98
|
@wojtekmach We could get more specific and pattern match on the message attributes but I am not sure there is much virtue in it. What do you think? |
josevalim
reviewed
May 2, 2024
The benefit of doing that is that, if there is a new format in the future, we won't try to accidentally decode without knowing what it actually is. |
The nil data case was originally fixed in #14 so I am leaving the explicit match for messages with nil data. The attribute match will cover the cases where no data attribute exists on the payload.
josevalim
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages with
payloadFormat: "NONE"may not contain the data attribute. Note something may have changed on Google's side because I believe this was previously handled by the nil check.Closes #98