brod supports sasl credentials from file
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`brod` supports having credentials in a file (which is good since they do not stay in the producer state and they are not exposed upon inspection). https://github.com/kafka4beam/brod/blob/master/README.md?plain=1#L425-L428
|
I'll squash commits before merging if the PR is accepted, since we are pointing to my branch HEAD in our systems at the moment. |
josevalim
reviewed
Jan 3, 2024
|
|
||
| defp validate_option(:sasl, {mechanism, path} = value) | ||
| when mechanism in [:plain, :scram_sha_256, :scram_sha_512] and | ||
| is_binary(path) do |
There was a problem hiding this comment.
To they actually allow the path to be a binary or must it be an Erlang string (i.e. Elixir charlist?)?
There was a problem hiding this comment.
We have it working as binary, I'm not sure if it allows a charlist, do you want me to check? I'm following the same typing approach as the existing username/password
There was a problem hiding this comment.
If it works as a binary, that's all we need.
|
@rewritten please update the tests too :) |
|
💚 💙 💜 💛 ❤️ |
|
@rewritten: Nice! Linked to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks! This PR adds support for file-based sasl credentials. From
brodreadme (https://github.com/kafka4beam/brod/blob/master/README.md?plain=1#L425-L428) (emphasis mine):