Update queue_url documentation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwilson512
suggested changes
Oct 30, 2019
| @@ -30,7 +30,7 @@ Broadway.start_link(MyBroadway, | |||
| producers: [ | |||
| default: [ | |||
| module: {BroadwaySQS.Producer, | |||
| queue_url: "https://us-east-2.queue.amazonaws.com/100000000001/my_queue" | |||
| queue_url: "https://sqs.amazonaws.com/1234567890/queue" | |||
There was a problem hiding this comment.
Examples in the AWS docs show this as https://queue.amazonaws.com not sqs.amazonaws.com
There was a problem hiding this comment.
I'm okay to update this, but the URL I posted is going to be what folks will get as a url from the console, however it looks like those legacy urls are still returned from aws-cli.
I'm fine either way I just wanted to make sure it was straightforward for new users that aren't as familiar with AWS. Maybe we should add both url formats under the queue url option example?
Link to issue: aws/aws-cli#1715
There was a problem hiding this comment.
Ah yes you're right, I ended up on the legacy docs. What you have is perfect, so 
|
❤️ 💚 💙 💛 💜 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the requested changes for #37 as I ran into the same thing with full queue urls. Also wanted to clarify the
wait_time_secondsdocumentation with a link to the AWS docs.Fixes #37