New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the example app to work with latest Broadway and Broadway SQS #56
Conversation
This commit is an attempt to upgrade the SQS Example application that resides in the `examples` directory.
I think we can also clean up and remove the comments of the config files, WDYT? |
Something else we could do is to change the example app to use Broadway.DummyProducer. This way, you no longer need to define a TestClient that has an empty receive_message. WDYT? |
I think the intention of the TestClient is to demonstrate that the |
Tge example app is meant to be an example for other devs, no? if so, best practice today is the dummy producer. The functionality is tested on sqs itself (if not, it should!). |
This is because we don't need to really interact with the SQS implementation in the tests.
@josevalim yes, makes sense! I changed to use |
Also add the example app to our CI pipeline.