-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DASHBUILDE-157: Metric displayer based on HTML templates #238
Conversation
Hi @dgutierr , there is an enforcer error: INFO] Fixing it and will continue the merge, if it's ok, will push ithe commits. |
After fixing the maven enforcer issue... tests failed :( Please can you review? Running org.dashbuilder.renderer.client.table.TableDisplayerTest testDraw(org.dashbuilder.renderer.client.metric.MetricDisplayerTest) Time elapsed: 0.004 sec <<< ERROR! testSwitchOffFilter(org.dashbuilder.renderer.client.metric.MetricDisplayerTest) Time elapsed: 0.001 sec <<< ERROR! testNoFilter(org.dashbuilder.renderer.client.metric.MetricDisplayerTest) Time elapsed: 0.003 sec <<< ERROR! testNoData(org.dashbuilder.renderer.client.metric.MetricDisplayerTest) Time elapsed: 0.003 sec <<< ERROR! Results : Tests in error: |
7462122
to
fa1a412
Compare
@Roger The issues you mentioned are fixed. Can you give it another try please? |
Hi @dgutierr , the build and tests are fine but I found an issue running the webapp (on Wildfly10). Creating a new metric displayer seems to work fine and really like the new stuff!! But the metric examples on the gallery are not working, nothing appears on those screens, no error on console at first glance.. but after some clicks ( back to gallery screen then back to the metrics example screen etc ) an error on the browser console appears. It does not happens when navigating to other gallery example screens, only after visiting the metrics one.. Can you please take a look at this before merging? Quite sure there is an error yet... :) Will wait for merge until getting your feedback! |
@romartin Fixed the gallery as well! |
fa1a412
to
f6520ca
Compare
Good :) |
Implementation of https://issues.jboss.org/browse/DASHBUILDE-157
Tests included.
@romartin Can you review & merge please?