AF-1149: Dashbuilder not closing ResultSets and Statements #420
Conversation
There was a problem hiding this comment.
@dgutierr - thanks for this fix, I tested it with the following results:
- track-statements=false - no more ORA-01000 errors 👍
- track-statements=true - still seeing WARN msgs from JCA about open statements in JDBCUtils.executeQuery ( line 75) 👎
Is this something that you could take another look at, please?
Closing a result set you left open! Please close it yourself.: java.lang.Throwable: STACKTRACE
at org.jboss.jca.adapters.jdbc.WrappedStatement.registerResultSet(WrappedStatement.java:1357)
at org.jboss.jca.adapters.jdbc.WrappedStatement.executeQuery(WrappedStatement.java:345)
at org.dashbuilder.dataprovider.sql.JDBCUtils.executeQuery(JDBCUtils.java:75) [dashbuilder-dataset-sql-0.5.0.Final-redhat-15-RHBPMS-5121.jar:0.5.0.Final-redhat-15-RHBPMS-5121]
|
@martinweiler Now should be fixed. I verified it on EAP with track-statements=true. The solution was a bit tricky tough. As the ironjacamar's WrappedConnection and WrappedStatement classes are implemented, it forces the client code to hold all the references to any ResultSet and Statement instances created so that they can be properly closed. Please give it another try. |
|
@dgutierr perfect, I just tried your new fix and it works as expected. Thank you! |
|
@martinweiler Great thanx. @kkufova Ready for QA :-) |
|
jenkins please retest this |
@jhrcek Fix + tests.
As this fix forces to close the opened result sets, the app server no longer warns or auto closes them, regardless the "track-statements" setting of the data source.