Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: provide state tree proofs #323

Merged
merged 2 commits into from
Dec 17, 2020
Merged

feat: provide state tree proofs #323

merged 2 commits into from
Dec 17, 2020

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Dec 16, 2020

Issue being fixed or feature implemented

Need to provide state tree proofs.

What was done?

Added prove parameter to platform requests, proof parameter to platform responses.

How Has This Been Tested?

Tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.17 milestone Dec 16, 2020
shumkov
shumkov previously approved these changes Dec 16, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Cofresi
Copy link
Contributor

Cofresi commented Dec 17, 2020

It looks to me as if our proof object doesn't have a version field. Is that true? If yes, then how do we plan to update the proof format, e.g. switching the state tree architecture backend to prefix solution instead of forrest?

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good 👍

@shumkov
Copy link
Member

shumkov commented Dec 17, 2020

@Cofresi protobuf itself provides backward compatibility model. Also, we have versioning in gRPC service name, so if we break it completely we just introduce a new version. Read more https://docs.google.com/document/d/1vq5R-bzz-FdgtBxi1EXTmGVPxoS6qvQ0B-tb7gADs4I/edit

@shuplenkov shuplenkov merged commit 61dac7f into v0.17-dev Dec 17, 2020
@shuplenkov shuplenkov deleted the feat/proofs branch December 17, 2020 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants