Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(wallet-lib): fix hanging functional test #186

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

markin-io
Copy link
Contributor

Issue being fixed or feature implemented

Fixing hanging functional test case

What was done?

Check whether the wallet already has a relevant transaction. If so, do not wait for BLOCK_HEADER event.

How Has This Been Tested?

yarn ultra -r --filter "packages/wallet-lib" test

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io changed the title fix(wallet-lib): hanging functional test test(wallet-lib): fix hanging functional test Jan 12, 2022
Copy link
Contributor

@Alex-Werner Alex-Werner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ! Perfect fix

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@markin-io markin-io merged commit c65dd03 into master Jan 12, 2022
@markin-io markin-io deleted the fix/wallet-test-hangs branch January 12, 2022 09:20
@shumkov shumkov added this to the v0.21.x milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants