Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide transaction history item as a date object #336

Merged
merged 6 commits into from
Apr 13, 2022
Merged

feat: provide transaction history item as a date object #336

merged 6 commits into from
Apr 13, 2022

Conversation

Alex-Werner
Copy link
Contributor

@Alex-Werner Alex-Werner commented Apr 8, 2022 •
edited
Loading

Issue being fixed or feature implemented

In most of our codebase, when a manipulation around time is being done, we provide it under the form of a date primitive.
The exception were done in the transaction history, where a history item were directly done under a UNIX timestamp format (seconds).
We therefore need to provide a valid JS Date format and ensure we use millisecond based timestamp to the passed primitive instance.

What was done?

  • feat: provide a Date primitive format for each history items

How Has This Been Tested?

  • Using current test suite

Breaking Changes

  • time property in getTransactionHistory is now a date.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

markin-io
markin-io approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@markin-io markin-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@Alex-Werner Alex-Werner merged commit 547c757 into v0.23-dev Apr 13, 2022
@Alex-Werner Alex-Werner deleted the feat/tx-history-date branch April 13, 2022 22:24
@thephez thephez added this to the v0.23.0 milestone Apr 14, 2022
markin-io pushed a commit that referenced this pull request Apr 25, 2022
@Alex-Werner @markin-io
feat: provide transaction history item as a date object (#336)
066d4b5 
* feat: provide transaction history item as a date object

* style: fix lint

* docs: update documentation

* docs: fix documentation conflict

* fix: conflict
@markin-io markin-io mentioned this pull request Apr 25, 2022
Merged
5 tasks
markin-io pushed a commit that referenced this pull request Apr 27, 2022
@Alex-Werner @markin-io
feat: provide transaction history item as a date object (#336)
afa214d 
* feat: provide transaction history item as a date object

* style: fix lint

* docs: update documentation

* docs: fix documentation conflict

* fix: conflict
@thephez thephez linked an issue Apr 27, 2022 that may be closed by this pull request
transactionHistory is a unix epoch timestamp instead of a javascript date object #264
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markin-io markin-io markin-io approved these changes

@shumkov shumkov Awaiting requested review from shumkov

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

transactionHistory is a unix epoch timestamp instead of a javascript date object
3 participants
@Alex-Werner @markin-io @thephez