Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(test-suite): skipSynchronizationBeforeHeight option with new wallet #34

Merged
merged 1 commit into from
Nov 12, 2021
Merged

test(test-suite): skipSynchronizationBeforeHeight option with new wallet #34

merged 1 commit into from
Nov 12, 2021

Conversation

shuplenkov
Copy link
Collaborator

Issue being fixed or feature implemented

Test suite fails with error if we use SKIP_SYNC_BEFORE_HEIGHT parameter.

What was done?

Fixed wallet contructor params

How Has This Been Tested?

Tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.21.x milestone Nov 12, 2021
@antouhou antouhou changed the title fix(platform-test-suite): useless skipSynchronizationBeforeHeight option error fix: useless skipSynchronizationBeforeHeight option error Nov 12, 2021
@antouhou antouhou changed the title fix: useless skipSynchronizationBeforeHeight option error fix(platform): useless skipSynchronizationBeforeHeight option error Nov 12, 2021
@antouhou antouhou changed the title fix(platform): useless skipSynchronizationBeforeHeight option error fix[platform]: useless skipSynchronizationBeforeHeight option error Nov 12, 2021
@antouhou antouhou changed the title fix[platform]: useless skipSynchronizationBeforeHeight option error fix(platform): useless skipSynchronizationBeforeHeight option error Nov 12, 2021
@antouhou antouhou changed the title fix(platform): useless skipSynchronizationBeforeHeight option error fix(platform-test-suite): useless skipSynchronizationBeforeHeight option error Nov 12, 2021
@shuplenkov shuplenkov changed the title fix(platform-test-suite): useless skipSynchronizationBeforeHeight option error test(test-suite): useless skipSynchronizationBeforeHeight option error Nov 12, 2021
@shumkov shumkov changed the title test(test-suite): useless skipSynchronizationBeforeHeight option error test(test-suite): do not use skipSynchronizationBeforeHeight option on new wallet Nov 12, 2021
@shumkov shumkov changed the title test(test-suite): do not use skipSynchronizationBeforeHeight option on new wallet test(test-suite): skipSynchronizationBeforeHeight option with new wallet Nov 12, 2021
shumkov
shumkov approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit de41541 into master Nov 12, 2021
@shumkov shumkov deleted the fix-skip-sync branch November 12, 2021 15:55
shumkov pushed a commit that referenced this pull request Nov 12, 2021
@shumkov
test(test-suite): skipSynchronizationBeforeHeight option with new w…
f81ae9d 
…allet (#34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov