Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: new node alpine image breaks package builds #493

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 18, 2022

Issue being fixed or feature implemented

Node image was updated recently nodejs/docker-node@9e9c0ec that was built with updated alpine image alpinelinux/docker-alpine@adebcfd

It seems alpine 3.16.2 did something bad with dependencies so NPM package builds doesn't work anymore

What was done?

  • Downgrade base image to node:16.16-alpine

How Has This Been Tested?

Locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou as a code owner August 18, 2022 15:55
@shumkov shumkov merged commit fe71331 into v0.23-dev Aug 18, 2022
@shumkov shumkov deleted the fix-docker-image-build branch August 18, 2022 17:02
@thephez thephez added this to the v0.23.0 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants