Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dpp): temporarily disable $refs in data contract definitions #300

Merged
merged 4 commits into from
Mar 17, 2022
Merged

feat(dpp): temporarily disable $refs in data contract definitions #300

merged 4 commits into from
Mar 17, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Mar 15, 2022

Issue being fixed or feature implemented

As GroveDB not supporting $refs at the moment, they are disabled in dpp for now.

What was done?

  • removed $ref definition in data contract meta schema

How Has This Been Tested?

Units and integration tests.

Breaking Changes

  • $ref in data contract definitions are not supported for now

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h requested a review from shumkov March 16, 2022 10:56
shumkov
shumkov approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit b31d4df into v0.22-dev Mar 17, 2022
@shumkov shumkov deleted the feat/disable-refs branch March 17, 2022 09:03
@thephez thephez added this to the v0.22.0 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shumkov @thephez