ci: Improvements to CI

[dashmug]

No description provided.

[sourcery-ai]

PR Type: Enhancement

PR Summary: This pull request introduces several enhancements to the Continuous Integration (CI) workflow. It reorganizes the CI jobs by separating shell script checks and Dockerfile validation into their own distinct jobs, streamlines the Python job by removing shell script checks from it, and adds a new step to verify if the requirements.txt file is up to date with the project's dependencies. Additionally, it simplifies the Makefile by removing the GROUP_ID variable from docker commands and adjusts the clean-notebooks target to support deeper nested Jupyter notebooks. Lastly, it removes the GROUP_ID build argument from the Docker Compose configuration.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.

• Sourcery currently only approves 'Typo fix' PRs.

✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.

No details provided.

📝 Complexity: the changes are too large or complex for Sourcery to approve.

• Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

• Ensure that the removal of GROUP_ID from Docker-related commands does not introduce permission issues, especially when dealing with volume mounts between the host and containers.
• Consider adding a step to automatically update and commit the requirements.txt file if it is found to be out of date during the CI process. This would prevent CI failures due to out-of-date dependencies.
• Verify that the new glob pattern used in the clean-notebooks target correctly identifies and cleans all intended Jupyter notebooks within the project, including those in deeply nested directories.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

• X
• Mastodon
• LinkedIn
• Facebook

---

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.